[Webkit-unassigned] [Bug 81659] [GTK] crash log reports support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81659





--- Comment #5 from Dirk Pranke <dpranke at chromium.org>  2012-03-21 13:37:17 PST ---
(In reply to comment #4)
> > > Tools/Scripts/webkitpy/common/system/executive.py:264
> > > +                return e.errno == errno.EPERM
> > 
> > Why is this change needed? I don't understand what was failing before or is fixed now ...
> > 
> 
> When I was testing our crashmon script and running it as root I was hitting this issue. Running the tests as a normal user I wasn't able to send the 0 signal to the crashmon process executed by root.
>

OK.

> > > Tools/Scripts/webkitpy/tool/commands/queries.py:375
> > > +        for port_name in tool.port_factory.all_port_names():
> > 
> > You probably don't want to iterate across all_port_names(), since that could presumably get you the same crash log multiple times.
> 
> So when I find the first, print it and exit early?

That's probably as good as anything else I can think of.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.