[Webkit-unassigned] [Bug 81443] [WebSocket]The minimal number of bytes MUST be used to encode the length

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81443





--- Comment #16 from Yuta Kitamura <yutak at chromium.org>  2012-03-21 11:19:55 PST ---
(From update of attachment 132976)
View in context: https://bugs.webkit.org/attachment.cgi?id=132976&action=review

I just have style comments. The code itself looks fine.

> LayoutTests/http/tests/websocket/tests/hybi/invalid-encode-length_wsh.py:16
> +    payloadLength, extendedLength = (match.group(1)).split('_', 1)

Should be payload_length, extended_length respectively.

We generally follow PEP8 in python files, so please take a look at it.

> LayoutTests/http/tests/websocket/tests/hybi/invalid-encode-length_wsh.py:18
> +    payloadLength = int (payloadLength)
> +    extendedLength = int (extendedLength)

Space after "int" is unnecessary.

> LayoutTests/http/tests/websocket/tests/hybi/invalid-encode-length_wsh.py:24
> +    if payloadLength == 126 :

Space before colon is unnecessary. For here and next two as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.