[Webkit-unassigned] [Bug 75824] check-webkit-style should warn about missing svn:mime-type for png files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75824





--- Comment #17 from Balazs Ankes <bank at inf.u-szeged.hu>  2012-03-21 10:13:09 PST ---
(In reply to comment #16)

> > Tools/Scripts/webkitpy/style/checkers/png.py:53
> > +        try:
> > +            detection = self.det.display_name()
> > +        except:
> 
> Do we need this try/except block?  When would this fail?
I thought it's necessary because the detection can get None value and that case display_name() won't working and throw error. (/Tools/Scripts/webkitpy/common/checkout/scm/detection.py, def detect_scm_system(self, path, patch_directories=None):)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.