[Webkit-unassigned] [Bug 81763] Web Inspector: build retainers phase it too slow in heap profiler

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81763


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #133023|1                           |0
        is obsolete|                            |




--- Comment #4 from Yury Semikhatsky <yurys at chromium.org>  2012-03-21 08:09:51 PST ---
(From update of attachment 133023)
View in context: https://bugs.webkit.org/attachment.cgi?id=133023&action=review

>> Source/WebCore/inspector/front-end/HeapSnapshot.js:976
>> +        var indexArray = this["_retainerIndex"] = new Int32Array(this._nodeIndex.length);
> 
> nodeCount

Please use this._retainerIndex syntax

>> Source/WebCore/inspector/front-end/HeapSnapshot.js:979
>> +        var nodeCount = this.nodeCount;
> 
> move it 4 lines up

Remember that this._nodeIndex.length !== nodeCount :)

> Source/WebCore/inspector/front-end/HeapSnapshot.js:999
> +            backRefsCount += indexArray[i];

backRefsCount === total edges count so you can calculate this in the previous loop and avoid additional pass through all elements.

> Source/WebCore/inspector/front-end/HeapSnapshot.js:1017
> +                var retNode = nodePositions[nodes[j * edgeFieldsCount + edgesOffset + edgeToNodeOffset]];

j * edgeFieldsCount + edgesOffset + edgeToNodeOffset -> edgeIndex + edgeToNodeOffset

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.