[Webkit-unassigned] [Bug 81763] Web Inspector: build retainers phase it too slow in heap profiler

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81763





--- Comment #2 from Ilya Tikhonovsky <loislo at chromium.org>  2012-03-21 06:56:13 PST ---
(From update of attachment 133023)
View in context: https://bugs.webkit.org/attachment.cgi?id=133023&action=review

looks good with nits

> Source/WebCore/inspector/front-end/HeapSnapshot.js:969
> +        if (!this._nodeIndex)
> +            this._buildNodeIndex();

unnecessary check

> Source/WebCore/inspector/front-end/HeapSnapshot.js:976
> +        var indexArray = this["_retainerIndex"] = new Int32Array(this._nodeIndex.length);

nodeCount

> Source/WebCore/inspector/front-end/HeapSnapshot.js:979
> +        var nodeCount = this.nodeCount;

move it 4 lines up

> Source/WebCore/inspector/front-end/HeapSnapshot.js:998
> +        for (i = 0, l = indexArray.length; i < l; ++i)

nodeCount

> Source/WebCore/inspector/front-end/HeapSnapshot.js:1004
> +        for (i = 0, l = indexArray.length; i < l; ++i) {

ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.