[Webkit-unassigned] [Bug 81084] Rendering replaced elements with percentage height within a table cell (with auto height)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81084





--- Comment #8 from arpitabahuguna at gmail.com  2012-03-21 06:06:04 PST ---
(In reply to comment #7)

Thanks for reviewing the patch Julien. I shall incorporate the changes as suggested by you and upload another patch shortly.

> The patch cannot be applied by our tools due to the SVN property (which doesn't look right to me anyway).

Could you please let me know as to why the patch could not be applied and how to rectify the same.

> 
> > Source/WebCore/rendering/RenderReplaced.cpp:590
> > +    return (style()->width().isPercent() || (style()->height().isPercent() && !isTableCellHeightAuto)
> > +        || style()->maxWidth().isPercent() || (style()->maxHeight().isPercent() && !isTableCellHeightAuto)
> > +        || style()->minWidth().isPercent() || (style()->minHeight().isPercent() && !isTableCellHeightAuto));
> 
> I don't understand why you single out height here. If you encountered a cell's containing block with auto or percent width, wouldn't you need the same exception?
> 
> Your testing would need to cover that too.
> 

Agree on the above and after further investigation would like to generalize the bug as "Rendering replaced elements with relative dimensions within a table cell (with auto\percent dimensions)".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.