[Webkit-unassigned] [Bug 13624] REGRESSION: can select text of an input button

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=13624


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132978|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #15 from Ryosuke Niwa <rniwa at webkit.org>  2012-03-20 23:28:53 PST ---
(From update of attachment 132978)
View in context: https://bugs.webkit.org/attachment.cgi?id=132978&action=review

r- due to inefficient implementation.

> Source/WebCore/rendering/RenderButton.h:51
> +    virtual bool canBeSelectionLeaf() const { return node()->rootEditableElement(); }

Finding rootEditableElement is very expensive. You should either call isContentEditable() or rendererIsEditable(). Call later if the layout is up-to-date whenever canBeSelectionLeaf is called.

> Source/WebCore/rendering/RenderTextFragment.h:42
> +    virtual bool canBeSelectionLeaf() const { return node()->rootEditableElement(); }

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.