[Webkit-unassigned] [Bug 71143] [Meta] Master bug for sub-pixel layout branch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71143





--- Comment #27 from WebKit Review Bot <webkit.review.bot at gmail.com>  2012-03-20 16:03:02 PST ---
Attachment 132916 did not pass style-queue:

Source/WebCore/platform/Length.h:33:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/Length.h:112:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/Length.h:116:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:82:  wtf_ceil is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:540:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:542:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:543:  is_specialized is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:552:  is_signed is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:553:  is_integer is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:554:  is_exact is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:558:  round_error is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:561:  min_exponent is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:562:  min_exponent10 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:563:  max_exponent is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:564:  max_exponent10 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:566:  has_infinity is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:567:  has_quiet_NaN is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:568:  has_signaling_NaN is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:569:  has_denorm is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:570:  has_denorm_loss is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:574:  quiet_NaN is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:576:  signaling_NaN is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:578:  denorm_min is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:581:  is_iec559 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:582:  is_bounded is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:583:  is_modulo is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:585:  Should have a space between // and comment  [whitespace/comments] [4]
SFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/WebCore.exp.in', u'Source/W..." exit_code: 1
ource/WebCore/platform/FractionalLayoutUnit.h:586:  tinyness_before is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:587:  round_style is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/rendering/RenderView.cpp:302:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/rendering/RenderTreeAsText.cpp:79:  The parameter name "behavior" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/rendering/RenderView.h:203:  The parameter name "r" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorPageAgent.cpp:54:  "FrameView.h" already included at Source/WebCore/inspector/InspectorPageAgent.cpp:53  [build/include] [4]
Source/WebCore/rendering/LayoutTypes.h:40:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 34 in 131 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.