[Webkit-unassigned] [Bug 80571] [mac] Restore color space switching code to run-webkit-tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80571


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132868|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #13 from Simon Fraser (smfr) <simon.fraser at apple.com>  2012-03-20 12:31:16 PST ---
(From update of attachment 132868)
View in context: https://bugs.webkit.org/attachment.cgi?id=132868&action=review

> Tools/DumpRenderTree/mac/LayoutTestHelper.m:38
> +// This is a simple helper app that changes the ColorSync profile to the

I think the comment should say "the color profile for the main display".

> Tools/DumpRenderTree/mac/LayoutTestHelper.m:51
> +    CFUUIDRef mainDisplay = CGDisplayCreateUUIDFromDisplayID(CGMainDisplayID());

mainDisplayID would be a better name.

> Tools/DumpRenderTree/mac/LayoutTestHelper.m:84
> +        fprintf(stderr, "Failed to set color profile for main display!  Many pixel tests may fail as a result.\n");

One space after the ! pls.

> Tools/DumpRenderTree/mac/LayoutTestHelper.m:117
> +    exit(128 + sig);

What is 128 + sig?

> Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm:59
> -    [m_window setColorSpace:[[NSScreen mainScreen] colorSpace]];
> +    [m_window setColorSpace:[NSColorSpace genericRGBColorSpace]];

Does DRT need a similar change?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.