[Webkit-unassigned] [Bug 81688] New: Incremental cleanup of BitmapImage: inlined virtual functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81688

           Summary: Incremental cleanup of BitmapImage: inlined virtual
                    functions
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Images
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: tomhudson at google.com
                CC: simon.fraser at apple.com, senorblanco at chromium.org,
                    jamesr at chromium.org


In the review of https://bugs.webkit.org/show_bug.cgi?id=65063, Darin Adler pointed out that it's rarely useful to have a virtual function defined in the header. That pattern occurs all over BitmapImage.h and BitmapImageSingleFrameSkia.h; we should fix that by moving all virtual function definitions to cpp files (adding one for BitmapImageSingleFrameSkia).

https://bugs.webkit.org/show_bug.cgi?id=66597 tracks larger-scale refactoring that should be done in this code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.