[Webkit-unassigned] [Bug 81361] [WebSocket]A client MUST close a connection if it detects a masked frame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81361





--- Comment #6 from Yuta Kitamura <yutak at chromium.org>  2012-03-20 10:31:43 PST ---
(From update of attachment 132417)
View in context: https://bugs.webkit.org/attachment.cgi?id=132417&action=review

Except for some style issues, the patch looks fine to me. (Please wait for comments from a reviewer, as I'm not a WebKit reviewer yet.)

> Source/WebCore/ChangeLog:7
> +        A client MUST close a connection if it detects a masked frame
> +        https://bugs.webkit.org/show_bug.cgi?id=81361
> +        A server MUST NOT mask any frames that it sends to the client.
> +
> +        Reviewed by NOBODY (OOPS!).

Usual ChangeLog format is:

  <bug title>
  <bug URL>

  Reviewed by ...

  <more description>

> Source/WebCore/Modules/websockets/WebSocketChannel.cpp:562
> +        fail("A server MUST NOT mask any frames that it sends to the client.");

Nitpick: Capital "MUST NOT" sounds too exaggerated; just small letters would work fine.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.