[Webkit-unassigned] [Bug 79104] Unaligned userspace access for SH4 platforms

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79104





--- Comment #5 from thouraya <thouraya.andolsi at st.com>  2012-03-20 09:24:53 PST ---
Hi,

Please,
Could you have a look on the patch ?

Thanks a lot.
thouraya.

(In reply to comment #3)
> (From update of attachment 127968 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127968&action=review
> 
> > Source/JavaScriptCore/assembler/MacroAssemblerSH4.h:978
> > +        m_assembler.ensureSpace(m_assembler.maxInstructionSize + 68, sizeof(uint32_t));
> > +        move(scr, SH4Registers::r0);
> > +        m_assembler.andlImm8r(0x3, SH4Registers::r0);
> > +        m_assembler.cmpEqImmR0(0x0, SH4Registers::r0);
> > +        m_assembler.branch(BF_OPCODE, 2 + extraInst);
> > +
> > +        if (dest != SH4Registers::r0)
> > +            move(scr1, SH4Registers::r0);
> > +
> > +        load32(scr, dest);
> > +        m_assembler.branch(BRA_OPCODE, 25 + extraInst);
> > +        m_assembler.nop();
> > +
> > +        m_assembler.andlImm8r(0x1, SH4Registers::r0);
> > +        m_assembler.cmpEqImmR0(0x0, SH4Registers::r0);
> > +
> > +        if (dest != SH4Registers::r0)
> > +            move(scr1, SH4Registers::r0);
> > +
> > +        m_assembler.branch(BF_OPCODE, 8);
> 
> Why aren't you just using the macro assembler API instead of having to manually compute branch offsets?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.