[Webkit-unassigned] [Bug 79354] [EFL] Add dummy GeolocationClientEfl.cpp | h

Tue Mar 20 05:56:19 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=79354

--- Comment #12 from Raphael Kubo da Costa <rakuco at FreeBSD.org>  2012-03-20 05:56:19 PST ---
(In reply to comment #10)
> I made this patch for reducing patch size. I thought that dividing large patch to smaller one will be better for reviewers.
> This bug item still exists, so I think starting the patch with this will be no proplem. How about your opinion?

I think reviewing this kind of skeleton code is quite simple in general, and it doesn't really contribute much to the complexity of the final, whole patch.

But the real problem I have is with committing this kind of dummy implementation and then not sending the actual code for a long time (or not implementing it at all), just like it happened to the previous geolocation code. There's also the risk that it takes a while between the two (or more) patches are committed.

At least I would really appreciate it if you could send the rest of the implementation code in a separate patch and create a dependency between the bug reports so that we can see the bigger picture. If such code doesn't exist yet, I'd refrain from asking for this patch to be reviewed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.