[Webkit-unassigned] [Bug 81294] Web Inspector: TypeBuilder: reduce raw methods visibility in generated types.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81294


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132166|review?                     |review-
               Flag|                            |




--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2012-03-20 04:45:25 PST ---
(From update of attachment 132166)
View in context: https://bugs.webkit.org/attachment.cgi?id=132166&action=review

One nit + you should run it through EWS.

> Source/WebCore/inspector/CodeGeneratorInspector.py:1229
> +            //COMPILE_ASSERT(false, weird_old_code);

We don't commit commented out code.

> Source/WebCore/inspector/CodeGeneratorInspector.py:1247
> +        // return Builder<NoFieldsSet>(adoptRef(new %s()));

ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.