[Webkit-unassigned] [Bug 71788] <area>-tag within <map> can get focus when it is hidden

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71788





--- Comment #8 from Antaryami Pandia <antaryami.pandia at motorola.com>  2012-03-20 03:09:35 PST ---
Thanks for the review. Will upload a modified patch.

Just one query regs "Node::isFocusable".
if (!renderer() || renderer()->style()->visibility() != VISIBLE)

I think only "if (!renderer())" should work. As per my understanding hidden and display none element doesn't have renderer.

(In reply to comment #7)
> (From update of attachment 132564 [details])
> This doesn't seem like the right approach. For one, I don't think checking for a renderer handles all visibility cases properly (e.g. visibility:hidden).
> 
> To me, the bug appears to be that HTMLAreaElement::isKeyboardFocusable() is lying to us by returning true even though the element is not visible and therefore not focusable. Other focusable nodes return false from isKeyboardFocusable() in this case (e.g. HTMLFormControlElement), so HTMLAraeElement should do this as well. In fact, it looks like the logic you want already exists in Node::isFocusable(), so the bug appears to be that HTMLAreaElement isn't properly delegating to its superclass.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.