[Webkit-unassigned] [Bug 77835] [GObject bindings] EventListeners as first-class GObjects: WebKitDOMEventListener

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77835





--- Comment #44 from C Anthony <anthony at xtfx.me>  2012-03-19 20:36:53 PST ---
(In reply to comment #43)
> :(In reply to comment #42)
> > (From update of attachment 132222 [details] [details])
> > r- now, because this patch made Qt EWS bots cry. After this patch they can't build patches anymore. :(((
> 
> :-/ whoopsie.

after chatting with mrobinson in #webkitgtk+ i realize that i edited the QT build:

Source/WebCore/DerivedSources.pri

... :-/ i thought i needed to enable the eventlistener for everyone, which in retrospect is obvious that i do not ... GObject is GTK+ only.  derp.  sorry.

> what can i do from here?  i just guidance/recommendation on how to proceed -- both approaches appear to work correctly.

... i also just now realized all set* or sink* methods on GObjectEventListener are totally unnecessary; GObjectEventListener can simply call:

WebKit::kit(this)

... to get a ref to it's companion WebKitDOMEventListener!!! of course! it's so simple! i'm going to spin one last patch that does this, and creates *_with_closure variants, possibly even:

add_event_listener_with_closure
[...]

... if needed.  i think i can maintain API (event though it's hopelessly broken), and ABI if possible (i dont know what all breaks this...).

could someone pretty please confirm this as a solution?  i really really (really) want to "X" out this bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.