[Webkit-unassigned] [Bug 81570] New: Properly align members in WebInputEvent and subclasses to make Valgrind happy

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 19 15:22:15 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=81570

           Summary: Properly align members in WebInputEvent and subclasses
                    to make Valgrind happy
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Event Handling
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: thestig at chromium.org


Currently, on 64-bit Linux, WebInputEvents have alignment issues with its data members that leave gaps in the in-memory representation. So even though one has initialized all the data members, Valgrind will still complain about uninitialized memory when Chromium readys WebInputEvents byte-by-byte when sending WebInputEvents over IPC.

To fix this, I've rearranged the data member order and added dummy padding members as needed. To ensure this problem does not occur in the future, I've added COMPILE_ASSERT() checks for all the classes to make sure there's no gaps.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list