[Webkit-unassigned] [Bug 81438] Add support for crossorigin attribute in script elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81438





--- Comment #6 from Pablo Flouret <pablof at motorola.com>  2012-03-19 14:38:37 PST ---
(In reply to comment #4)
> (From update of attachment 132433 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=132433&action=review
> 
> > Source/WebCore/dom/ScriptElement.cpp:320
> > +    if (m_element->fastHasAttribute(HTMLNames::crossoriginAttr)
> 
> So, this isn't 100% correct.  We should lock in the notion of whether this is a crossorigin load when the load is initiated.  By re-checking the attribute here, we might get a different value the second time.  That's an extremely minor bug though.

Yeah, good catch. ImageLoader::notifyFinished() should probably be fixed as well (although the code there doesn't really prevent the image from loading at the moment, i guess there's bug 80028 for that).

(In reply to comment #5)
> (Obviously, we should address the EFL failure before landing this patch.)

EFL woes look unrelated, i'll upload a new patch and see if ews comes to the rescue.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.