[Webkit-unassigned] [Bug 77368] [chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77368





--- Comment #3 from Tony Chang <tony at chromium.org>  2012-03-19 12:01:55 PST ---
I tracked this down since I had another ref test fail.

The bug is here: http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp#L51

WebRect is defined as a point + width/height.  SkIRect is a left, top, right and bottom edge.  The conversion needs to subtract 1 from the width and the height.

For example, suppose WebRect is at 0, 0 and has a width and height of 10.  This converts to a SkIRect with points at 0, 0, 10, 10, but that's actually a width and height of 11.

This also explains why we don't have right/bottom edges on any of our scrollbars, e.g.:
http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium-win/css1/basic/class_as_selector-expected.png

We'll need to rebaseline many tests, e.g., all textareas and all scrollbars are different.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.