[Webkit-unassigned] [Bug 81269] [BlackBerry] Use BlackBerry::Platform::DeviceInfo to generate UserAgent

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 19 10:57:44 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=81269


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132603|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #3 from Rob Buis <rwlbuis at gmail.com>  2012-03-19 10:57:45 PST ---
(From update of attachment 132603)
View in context: https://bugs.webkit.org/attachment.cgi?id=132603&action=review

LGTM.

> Source/WebKit/blackberry/Api/WebPage.cpp:5683
> +        BlackBerry::Platform::DeviceInfo* info = BlackBerry::Platform::DeviceInfo::instance();

You can probably leave off BlackBerry:: prefix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list