[Webkit-unassigned] [Bug 81515] SVG Resources layout needs refactoring

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 19 10:21:31 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=81515





--- Comment #4 from Stephen Chenney <schenney at chromium.org>  2012-03-19 10:21:32 PST ---
removeAllClientsFromCache calls setNeedsLayout, during layout, which is generally bad form.

I know that SVGRenderSupport, during layout, calls setNeedsLayout on children, but that is OK because they are children and the layout flags are explicitly not allowed to escape the child's subtree. However, code inside removeAllClientsFromCache calls setNeedsLayout all over the tree, including on things already laid out in the current layout pass.

The comments in #1 may also indicate why we are getting the bounding box for filter elements wrong. See bug 77660.

The fact that removeAllClientsFromCache is needed at all implies that other objects depend on things that occur during resource layout. Otherwise, why would we need to invalidate the thing using the resource?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list