[Webkit-unassigned] [Bug 76166] [WK2][GTK] FullScreen signals

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76166





--- Comment #16 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-03-19 07:05:25 PST ---
(In reply to comment #14)
> (From update of attachment 131323 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=131323&action=review
> 
> >> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:67
> >> +    LEAVING_FULLSCREEN,
> > 
> > I would call these ENTER and LEAVE, since you can control whether to enter/leave fullscreen. Other signal names use the same pattern.
> 
> Hrmm this API was discussed in the mailing list, no one complained on this name and I implemented it for WebKit1... So... Do we want to remain consistent here or not? I don't mind changing this now but it feels late already (IMHO).

In WebKit1 there are other signals using that approach like WebKitWebView::hovering-over-link or WebKitWebView::resource-request-starting. The ing form sounds more like a notification, not something that you can control or avoid. In this case enter/leave fullscreen signals are not just a notification that something is going to happen, you can use them to avoid it to happen or even provide your own implementation. In WebKit2 we usually use the past for notification about things that already happened (load-changed, load-failed, mouse-target-changed, print-request) and imperative for signals that you can block or provide your own implementation (create, close, decide-policy). That's why I thought it would be better to use enter/leave instead of entering/leaving in WebKit2.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.