[Webkit-unassigned] [Bug 79851] Return value from executed script in Chromium.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79851





--- Comment #19 from Adam Barth <abarth at webkit.org>  2012-03-19 00:10:58 PST ---
(From update of attachment 132400)
View in context: https://bugs.webkit.org/attachment.cgi?id=132400&action=review

This is much better than the previous iterations.

> Source/WebCore/bindings/v8/V8Proxy.cpp:265
> +        if (results)

Can we move this test outside of the loop?  I guess the compiler will probably do that optimization of us...

> Source/WebKit/chromium/src/WebFrameImpl.cpp:906
> +        sources.append(ScriptSourceCode(
> +            sourcesIn[i].code, sourcesIn[i].url, position));

No need to wrap at 80 cols

> Tools/DumpRenderTree/chromium/LayoutTestController.cpp:1350
> +        // TODO: There are many more types that can be handled.

TODO => FIXME

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.