[Webkit-unassigned] [Bug 80134] [CSSRegions]Implement NamedFlow::contentNodes attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80134





--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org>  2012-03-19 00:04:02 PST ---
(From update of attachment 132487)
View in context: https://bugs.webkit.org/attachment.cgi?id=132487&action=review

> LayoutTests/fast/regions/webkit-named-flow-content-nodes-expected.txt:7
> +PASS
> +PASS
> +PASS

Please consider including some information about which test cases are passing. It makes debugging really hard if one of these passes turn into fail on some bots.

> Source/WebCore/dom/Document.cpp:1040
> +PassRefPtr<WebKitNamedFlow> Document::webkitGetFlowByName(const String& flowName, bool checkFlowName)

Please use enum instead of bool.

> Source/WebCore/dom/Document.cpp:1050
> +        CSSParser p(true);

Please don't use one-letter variables.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.