[Webkit-unassigned] [Bug 81323] [Mac][Chromium] Should not spellcheck text pasted to an element having spellcheck disabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81323





--- Comment #3 from Hajime Morrita <morrita at google.com>  2012-03-18 20:49:29 PST ---
(From update of attachment 132237)
View in context: https://bugs.webkit.org/attachment.cgi?id=132237&action=review

>> Source/WebCore/editing/Editor.cpp:425
>>      m_spellChecker->requestCheckingFor(SpellCheckRequest::create(resolveTextCheckingTypeMask(TextCheckingTypeSpelling | TextCheckingTypeGrammar), TextCheckingProcessBatch, rangeToCheck, rangeToCheck));
> 
> It's probably better to check the above conditions inside requestCheckingFor. Or maybe add a variant like requestCheckingForIfEnabled.

IMHO, such kind of defensiveness isn't good idea. 
My suggestion is to 
- add SpellChecker::isCheckable(Range*) and check it before invoking requestCheckingFor()
- assert it inside requestCheckingFor().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.