[Webkit-unassigned] [Bug 81102] blur() on shadow host should work when a shadow host contains a focused element in its shadow DOM subtrees.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 18 19:53:01 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=81102





--- Comment #26 from Hayato Ito <hayato at chromium.org>  2012-03-18 19:53:01 PST ---
(From update of attachment 132277)
View in context: https://bugs.webkit.org/attachment.cgi?id=132277&action=review

> Source/WebCore/dom/TreeScope.cpp:190
> +    Document* document = rootNode()->document();

Could you move this line to inside of 'if' statement (L192)? Since 'document' is used only in the if statement.

> Source/WebCore/dom/TreeScope.h:50
> +    Node* focusedNodeInTree();

I don't think focusedNodeInTree() is intuitive name because the meaning of 'Tree' here is not clear.
focusedNodeInTreeScope() might be better. Or focusedNode() is simply enough in this context.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list