[Webkit-unassigned] [Bug 80823] [GStreamer] run AudioFileReader in a nested loop

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80823





--- Comment #10 from Philippe Normand <pnormand at igalia.com>  2012-03-17 04:35:20 PST ---
(In reply to comment #8)
> (From update of attachment 132230 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=132230&action=review
> 
> > Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:332
> > +    GstBus* bus = gst_pipeline_get_bus(GST_PIPELINE(m_pipeline));
> > +    g_signal_handlers_disconnect_by_func(bus, reinterpret_cast<gpointer>(messageCallback), this);
> > +    gst_object_unref(bus);
> 
> You could use a RefPtr here with adoptRef.
> 

Right, I added GstBus support in GRefPtrGStreamer!

> > Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:334
> > +    g_signal_handlers_disconnect_by_func(m_decodebin.get(), reinterpret_cast<gpointer>(onGStreamerDecodebinPadAddedCallback), this);
> 
> Do you need to release m_decodeBin or does it happen later automatically?

Hum when the pipeline is unreffed all its elements are cleared as well AFAIK. But I just explicitely clear out the decodebin and deinterleave smart pointers too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.