[Webkit-unassigned] [Bug 81387] MathML internals - factor code for almost anonymous blocks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81387





--- Comment #9 from Julien Chaffraix <jchaffraix at webkit.org>  2012-03-16 19:17:51 PST ---
> Julien, soon we'll switch to an anonymous RenderBlock, I think. The best answer ultimately might be some new RenderPadded or RenderWrapped or whatever that might not even derive from RenderBlock, as we discussed. 

I had in mind that RenderMathMLBlock would get this padding as this was the natural continuation of the existing code and would enable most wrappers to be anonymous. Adding new renderers for some intrinsic padding is definitely cleaner though. The other comments were mostly around this line of thoughts so likely off.

> I tried m_scripts->createAlmostAnonymousBlock() but tests failed. The problem is that the setStyle(), or some styleDidChange() or something, must happen *after* some of the style changes here (for scriptsStyle) that are more than just e.g. setting a padding. The code here seemed simplest.

It's unfortunate indeed and I don't see any way around that as you need your style setup for styleDidChange.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.