[Webkit-unassigned] [Bug 81425] New: 'isSVGW3CTest' in DumpRenderTree should check for forward slash like TestInvocation
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 16 16:09:29 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=81425
Summary: 'isSVGW3CTest' in DumpRenderTree should check for
forward slash like TestInvocation
Product: WebKit
Version: 528+ (Nightly build)
Platform: PC
OS/Version: Windows 7
Status: UNCONFIRMED
Severity: Normal
Priority: P2
Component: Tools / Tests
AssignedTo: webkit-unassigned at lists.webkit.org
ReportedBy: lynn.neir at skype.net
In DumpRenderTree in function sizeWebViewForCurrentTest() it currently only tests for Windows style path. It should also check for forward slash, similar to what is done in TestInvocation.
Current code:
static void sizeWebViewForCurrentTest()
{
bool isSVGW3CTest = (gLayoutTestController->testPathOrURL().find("svg\\W3C-SVG-1.1") != string::npos);
unsigned width;
unsigned height;
if (isSVGW3CTest) {
width = 480;
height = 360;
} else {
width = LayoutTestController::maxViewWidth;
height = LayoutTestController::maxViewHeight;
}
::SetWindowPos(webViewWindow, 0, 0, 0, width, height, SWP_NOMOVE);
}
Proposed new code:
static void sizeWebViewForCurrentTest()
{
bool isSVGW3CTest = (gLayoutTestController->testPathOrURL().find("svg\\W3C-SVG-1.1") != string::npos) || (gLayoutTestController->testPathOrURL().find("svg/W3C-SVG-1.1") != string::npos);
unsigned width;
unsigned height;
if (isSVGW3CTest) {
width = 480;
height = 360;
} else {
width = LayoutTestController::maxViewWidth;
height = LayoutTestController::maxViewHeight;
}
::SetWindowPos(webViewWindow, 0, 0, 0, width, height, SWP_NOMOVE);
}
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list