[Webkit-unassigned] [Bug 79435] incorrect line-height for styled menulist (select tag) in windows theme (wincairo port)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=79435





--- Comment #5 from Lynn Neir <lynn.neir at skype.net>  2012-03-16 13:22:22 PST ---
(In reply to comment #4)
> Attachment 132307 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
> Source/WebCore/ChangeLog:4:  Line contains tab character.  [whitespace/tab] [5]
> Source/WebCore/ChangeLog:5:  Line contains tab character.  [whitespace/tab] [5]
> Source/WebCore/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
> Source/WebCore/ChangeLog:7:  Line contains tab character.  [whitespace/tab] [5]
> Source/WebCore/ChangeLog:8:  Line contains tab character.  [whitespace/tab] [5]
> Source/WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
> Source/WebCore/ChangeLog:13:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]

style errors are false positives, style check ran fine for me.

as explained earlier:
This patch fixes line-height issue in three tests:
- fast/forms/menulist-restrict-line-height.html
- fast/forms/control-restrict-line-height.html
- fast/forms/basic-selects.html

I didn't include changes to wincairo platform Skipped file as it seems test scripts are not setup to use the skipped file.  I verified results by running winlauncher and visually comparing results to Safari/Chrome.

> Total errors found: 7 in 2 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.