[Webkit-unassigned] [Bug 81361] [WebSocket]A client MUST close a connection if it detects a masked frame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81361





--- Comment #3 from Yuta Kitamura <yutak at chromium.org>  2012-03-16 10:19:40 PST ---
(From update of attachment 132303)
View in context: https://bugs.webkit.org/attachment.cgi?id=132303&action=review

This is a good thing to do. Thanks for doing this.

> Source/WebCore/Modules/websockets/WebSocketChannel.cpp:647
> +    if (frame.masked) {
> +        fail("A server MUST NOT mask any frames that it sends to the client.");
> +        return false;
> +    }
> +

This check should be done inside parseFrame(), and you can safely remove unmasking code there (line 595-600).

You can also remove the stale comment in WebSocketChannel.h ("May modify part of ...").

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.