[Webkit-unassigned] [Bug 80823] [GStreamer] run AudioFileReader in a nested loop

Fri Mar 16 10:01:00 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=80823

Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132230|review?                     |review+
               Flag|                            |

--- Comment #8 from Martin Robinson <mrobinson at webkit.org>  2012-03-16 10:01:00 PST ---
(From update of attachment 132230)
View in context: https://bugs.webkit.org/attachment.cgi?id=132230&action=review

> Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:332
> +    GstBus* bus = gst_pipeline_get_bus(GST_PIPELINE(m_pipeline));
> +    g_signal_handlers_disconnect_by_func(bus, reinterpret_cast<gpointer>(messageCallback), this);
> +    gst_object_unref(bus);

You could use a RefPtr here with adoptRef.

> Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:334
> +    g_signal_handlers_disconnect_by_func(m_decodebin.get(), reinterpret_cast<gpointer>(onGStreamerDecodebinPadAddedCallback), this);

Do you need to release m_decodeBin or does it happen later automatically?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.