[Webkit-unassigned] [Bug 76166] [WK2][GTK] FullScreen signals

Fri Mar 16 08:59:25 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=76166

--- Comment #14 from Philippe Normand <pnormand at igalia.com>  2012-03-16 08:59:25 PST ---
(From update of attachment 131323)
View in context: https://bugs.webkit.org/attachment.cgi?id=131323&action=review

>> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:67
>> +    LEAVING_FULLSCREEN,
> 
> I would call these ENTER and LEAVE, since you can control whether to enter/leave fullscreen. Other signal names use the same pattern.

Hrmm this API was discussed in the mailing list, no one complained on this name and I implemented it for WebKit1... So... Do we want to remain consistent here or not? I don't mind changing this now but it feels late already (IMHO).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.