[Webkit-unassigned] [Bug 81102] blur() on shadow host should work when a shadow host contains a focused element in its shadow DOM subtrees.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81102


Hajime Morrita <morrita at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132250|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #17 from Hajime Morrita <morrita at google.com>  2012-03-16 04:59:17 PST ---
(From update of attachment 132250)
View in context: https://bugs.webkit.org/attachment.cgi?id=132250&action=review

Almost good. Could you take care of small points?

> Source/WebCore/dom/Element.cpp:1591
> +bool Element::nodeIsInShadowTree(Node* focused)

|focused| looks too specific name.
This method doesn't need to mention about focus.

> Source/WebCore/dom/Element.cpp:1594
> +    if (hasShadowRoot()) {

Let's return here.
WebKit prefers early return style.

> Source/WebCore/dom/Element.cpp:1613
> +    Node* focusedNode = doc->focusedNode();

Yeah, this looks making more sense.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.