[Webkit-unassigned] [Bug 80854] [Qt][Wk2] Assertion Failure and crash on file upload

Fri Mar 16 04:44:54 PDT 2012

https://bugs.webkit.org/show_bug.cgi?id=80854

Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #132063|review?                     |review+
               Flag|                            |

--- Comment #13 from Simon Hausmann <hausmann at webkit.org>  2012-03-16 04:44:54 PST ---
(From update of attachment 132063)
View in context: https://bugs.webkit.org/attachment.cgi?id=132063&action=review

r=me. The style nitpick and the member variable should be fixed before landing.

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:383
> +    openPanelResultListener = listenerRef;

It looks like this member variable could be removed, now that we process the file picking "synchronously".

> Source/WebKit2/UIProcess/qt/QtDialogRunner.cpp:171
> +    QStringList fileList() const {return m_fileList; }

Missing space after opening {

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.