[Webkit-unassigned] [Bug 81102] blur() on shadow host should work when a shadow host contains a focused element in its shadow DOM subtrees.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81102





--- Comment #6 from Hayato Ito <hayato at chromium.org>  2012-03-16 02:18:01 PST ---
(From update of attachment 132226)
View in context: https://bugs.webkit.org/attachment.cgi?id=132226&action=review

> Source/WebCore/dom/Element.cpp:1608
> +    // if shadowHost is not found return. This handles case where focused node

Could you modify this comment?
I think we can remove a comment of 'if shadowHost is not found return.'  since it does not explain the exact situation here.

> LayoutTests/fast/dom/shadow/shadow-root-blur.html:41
> +shouldBe("getElementInShadowTreeStack('shadowHostA/').activeElement", "null");

We should rename getElementInShadowTreeStack since it can return ShadowRoot, which is not Element.
That is an unintentional usage for me that it can return ShadowRoot. So we should rename it to getNodeInShadowTreeStack.

Could you update shadow-dom.js and other files which use getElementInShadowTreeStack?
It is okay that you will do it in another patch. If you do it in another patch, please add 'FIXME: Rename ...' comment on getElemetnInShadowTreeStack in shadow-dom.js.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.