[Webkit-unassigned] [Bug 77835] [GObject bindings] EventListeners as first-class GObjects: WebKitDOMEventListener

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77835





--- Comment #37 from WebKit Review Bot <webkit.review.bot at gmail.com>  2012-03-16 00:59:40 PST ---
Attachment 132222 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/bindings/gobject/WebKitDOMEventTarget.cpp:79:  webkit_dom_event_target_add_event_listener is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/bindings/gobject/WebKitDOMEventTarget.cpp:92:  webkit_dom_event_target_remove_event_listener is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WARNING: File exempt from style guide. Skipping: "Source/WebKit/gtk/tests/testdomdomwindow.c"
Source/WebCore/bindings/gobject/WebKitDOMEventTarget.h:48:  Extra space between gboolean and useCapture  [whitespace/declaration] [3]
Source/WebCore/bindings/gobject/WebKitDOMEventTarget.h:52:  Extra space between gboolean and useCapture  [whitespace/declaration] [3]
Source/WebCore/bindings/gobject/WebKitDOMEventTarget.h:62:  The parameter name "target" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/bindings/gobject/WebKitDOMEventTarget.h:64:  The parameter name "listener" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/bindings/gobject/WebKitDOMEventTarget.h:65:  Extra space between gboolean and useCapture  [whitespace/declaration] [3]
Source/WebCore/bindings/gobject/WebKitDOMEventTarget.h:67:  The parameter name "target" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/bindings/gobject/WebKitDOMEventTarget.h:69:  The parameter name "listener" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/bindings/gobject/WebKitDOMEventTarget.h:70:  Extra space between gboolean and useCapture  [whitespace/declaration] [3]
Source/WebCore/bindings/gobject/GObjectEventListener.h:51:  The parameter name "destroyNotify" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/bindings/gobject/GObjectEventListener.h:55:  The parameter name "destroyNotify" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/bindings/gobject/GObjectEventListener.cpp:28:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/bindings/gobject/WebKitDOMCustom.h:50:  The parameter name "destroy" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 15 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.