[Webkit-unassigned] [Bug 80760] WinLauncher should show loading errors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80760





--- Comment #30 from Ashod Nakashian <ashodnakashian at yahoo.com>  2012-03-15 23:57:14 PST ---
(In reply to comment #29)
> (In reply to comment #28)
> > Created an attachment (id=132055)
 --> (https://bugs.webkit.org/attachment.cgi?id=132055&action=review) [details] [details]
> > Patch
> > 
> > Why parameters unused in the implementation should be removed from the declaration is inexplicable to me.
> 
> The pragmatic reason is that it silences a compiler warning, making it easier to notice warnings that have real consequences.

That's only true for implementations, not for declarations (there is no 'usage' at declaration point).

> 
> The higher-level reason is that it signals to people reading the sources that the parameter is not used.

Reasonable, but I think this promises more than it warrants. For example an update might start using these parameters. I think the correct reference for what's used and what's not is the docs, which defines the contract, not the code, which is only an implementation, not the only possible one.

> 
> If you like, you can comment out the name of the parameter (e.g., "... double /*blah*/, int used, ...").

Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.