[Webkit-unassigned] [Bug 80981] [GTK] [WK2] Add javascript clipboard functionality settings to WebKit2 GTK+ API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80981





--- Comment #21 from Antaryami Pandia <antaryami.pandia at motorola.com>  2012-03-15 22:41:41 PST ---
Thanks for the review.

(In reply to comment #20)
> (From update of attachment 132005 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=132005&action=review
> 
> Did you see my comment? Perhaps we should just expose WebKitSettings:javascript-can-access-clipboard and make it control both WKPreferencesSetJavaScriptCanAccessClipboard and WKPreferencesSetDOMPasteAllowed. I'm curious to here what others think.

I saw your comments, but I thought you are just referring to the implementation of qt port.  I agree with you. Even I have also asked for the feedback about the same in my comment #10 - "So do we required both the settings or we can have a single settings, say "enable-javascript-cutcopypaste" or any better name?".

will do and put it under one settings "javascript-can-access-clipboard".

> > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:861
> > +     * set to %TRUE, then it allows cut/copy command to be executed when
> 
> Nit: allows cut and copy commands

will do.

> > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:862
> > +     * invoked from java script by using document.execCommand().
> 
> java script -> JavaScript

will do.

> > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:867
> > +                                                         _("JavaScript can access Clipboard"),
> 
> Clipboard -> clipboard

will do.

> > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:876
> > +     * is %FALSE. If set to %TRUE, then it allows paste command to be
> 
> allows paste command -> allows paste commands

will do.

> > Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:877
> > +     * executed when invoked from java script by using document.execCommand().
> 
> JavaScipt

will do.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.