[Webkit-unassigned] [Bug 73176] Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73176





--- Comment #22 from Dongwoo Joshua Im <dw.im at samsung.com>  2012-03-15 18:53:00 PST ---
(In reply to comment #21)
> (From update of attachment 121962 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=121962&action=review
> 
> > Source/WebCore/page/Chrome.cpp:374
> > +String Chrome::isProtocolHandlerRegistered(const String& scheme, const String& baseURL, const String& url)
> > +{
> > +    return m_client->isProtocolHandlerRegistered(scheme, baseURL, url);
> > +}
> > +
> > +void Chrome::unregisterProtocolHandler(const String& scheme, const String& baseURL, const String& url)
> > +{
> > +    m_client->unregisterProtocolHandler(scheme, baseURL, url);
> > +}
> 
> This functions are unnecessary.  The ChromeClient is visible publicly.  You can just call methods on it directly.  (Feel free to remove Chrome::registerProtocolHandler as well.)

Then, I will remove the three functions from Chrome.h/cpp.

> 
> > Source/WebCore/page/Navigator.cpp:289
> > +String Navigator::isProtocolHandlerRegistered(const String& scheme, const String& url, ExceptionCode& ec)
> 
> I thought we moved Navigator::registerProtocolHandler out of Navigator.cpp.
> 
> > Source/WebCore/page/Navigator.cpp:292
> > +        return "declined";
> 
> This should be a constant so you don't need to repeat it four times.

OK.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.