[Webkit-unassigned] [Bug 78856] visual word movement: Using ICU break iterator to simplify implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78856





--- Comment #22 from Ryosuke Niwa <rniwa at webkit.org>  2012-03-15 12:50:37 PST ---
(In reply to comment #21)
> (In reply to comment #17)
> > (From update of attachment 131956 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=131956&action=review
> > >> Source/WebCore/editing/visible_units.cpp:166
> > >> +    root->collectLeafBoxesInLogicalOrder(leafBoxesInLogicalOrder);
> > > 
> > > Wait... I don't think this is right. The only time we need to clear the cache is when we move onto a new root inline box.
> > 
> > the function only called when we move onto a  new root inline box. And it called continuously when moving to different root inline box so need to clear the vector.
> 
> But visualWordPosition moves one character at the time, right? So logicallyPreviousBox/logicallyNextBox can be called for the box in the same root inline box.

The easiest way to do this is to wrap the vector in some class, and then add collectLeafBoxesInLogicalOrder(RootInlneBox*) m_rootInlineBox as members. collectLeafBoxesInLogicalOrder would then check if the new root inline box is same as m_rootInlineBox or not, and if not, clears the vector and does root->collectLeafBoxesInLogicalOrder(this);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.