[Webkit-unassigned] [Bug 78856] visual word movement: Using ICU break iterator to simplify implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=78856





--- Comment #19 from Ryosuke Niwa <rniwa at webkit.org>  2012-03-15 12:26:12 PST ---
> >> Source/WebCore/editing/visible_units.cpp:180
> >> +    for (int j = previousBoxIndex; j >= 0; --j) {
> > 
> > We can use i here again.
> 
> this one can not. Since prevBoxIndex could be -1 and can not be assigned to size_t. Also because of the name scope.

What I meant is that you can call it i instead of j. i.e.

for (int i = previousBoxIndex; i >= 0; --i) {

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.