[Webkit-unassigned] [Bug 80854] [Qt][Wk2] Assertion Failure and crash on file upload

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 15 08:52:04 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=80854





--- Comment #10 from Dinu Jacob <dinu.jacob at Nokia.com>  2012-03-15 08:52:04 PST ---
(In reply to comment #7)
> (From update of attachment 131918 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=131918&action=review
> 
> Not a review, but a few comments.
> 
> > Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h:280
> > +    QDeclarativeComponent* filePicker() const;
> > +    void setFilePicker(QDeclarativeComponent*);
> 
> It is fine that this is an experimental API, as it might make sense to join it with the media capturer in the near future, so you have something like
> 
> mediaPicker("file/*");
> mediaPicker("images/capture");
> 
> [or whatever those mimetypes are called]
> 
> Maybe it makes sense to prepare for this already?
> 
As per IRC discussion, will keep it as FilePicker and later add a property for the mime types.
> > Source/WebKit2/UIProcess/API/qt/tests/qmltests/common/singlefileupload.html:10
> > +    var name=new String("");
> 
> missing space around =
> 
Will fix this.
> > Tools/MiniBrowser/qt/qml/FilePicker.qml:29
> > +import Qt.labs.folderlistmodel 1.0
> 
> Do we have this available?
> 
This is part of QtDeclarative, available as a separate plugin under Qt labs. As per IRC discussion with Simon, ok to use this.
> > Tools/MiniBrowser/qt/qml/FilePicker.qml:203
> > +}
> > +
> > +
> > +
> > +
> > +
> 
> what is up with the newlines?
Will remove those

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list