[Webkit-unassigned] [Bug 80854] [Qt][Wk2] Assertion Failure and crash on file upload

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80854





--- Comment #7 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-03-15 07:15:36 PST ---
(From update of attachment 131918)
View in context: https://bugs.webkit.org/attachment.cgi?id=131918&action=review

Not a review, but a few comments.

> Source/WebKit2/UIProcess/API/qt/qquickwebview_p.h:280
> +    QDeclarativeComponent* filePicker() const;
> +    void setFilePicker(QDeclarativeComponent*);

It is fine that this is an experimental API, as it might make sense to join it with the media capturer in the near future, so you have something like

mediaPicker("file/*");
mediaPicker("images/capture");

[or whatever those mimetypes are called]

Maybe it makes sense to prepare for this already?

> Source/WebKit2/UIProcess/API/qt/tests/qmltests/common/singlefileupload.html:10
> +    var name=new String("");

missing space around =

> Tools/MiniBrowser/qt/qml/FilePicker.qml:29
> +import Qt.labs.folderlistmodel 1.0

Do we have this available?

> Tools/MiniBrowser/qt/qml/FilePicker.qml:203
> +}
> +
> +
> +
> +
> +

what is up with the newlines?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.