[Webkit-unassigned] [Bug 78856] visual word movement: Using ICU break iterator to simplify implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 14 16:43:29 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=78856


Xiaomei Ji <xji at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #131476|0                           |1
        is obsolete|                            |
 Attachment #131956|                            |review?
               Flag|                            |




--- Comment #15 from Xiaomei Ji <xji at chromium.org>  2012-03-14 16:43:27 PST ---
Created an attachment (id=131956)
 --> (https://bugs.webkit.org/attachment.cgi?id=131956&action=review)
patch w/ layout test

I did not consolidate previousRootInlineBox with the functionality in previousLinePosition. There are a couple of differences there (for example, the RenderPosition and ShadowNode), and I am hesitate to change previousLinePosition() in this patch to make it more inline with previousRootInlineBox. And consolidate to a single function with parameters to control different requirement looks not nice.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list