[Webkit-unassigned] [Bug 41630] DNS prefetching spams resolver, shoots self in the foot

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41630





--- Comment #14 from Martin Robinson <mrobinson at webkit.org>  2012-03-14 10:36:58 PST ---
(From update of attachment 131831)
View in context: https://bugs.webkit.org/attachment.cgi?id=131831&action=review

Looks good. I have a couple nits below.  We should probably at least have a plan with how to deal with the proxy issue.

> Source/WebCore/platform/network/soup/DNSSoup.cpp:30
>  
>  #include "CString.h"

I think you need to expand the Apple copyright to 2009 to match DNSCFNet.

> Source/WebCore/platform/network/soup/DNSSoup.cpp:102
> +    // if (proxyURI || soup_session_get_feature(soupSession, SOUP_TYPE_PROXY_URI_RESOLVER))

Simply remove commented out code.

> Source/WebCore/platform/network/soup/DNSSoup.cpp:158
> +static void resolvedCallback(SoupAddress *soupAddress, guint status, gpointer userData)

Small style issue here with asterisk placement. Please use void* intead of gpointer.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.