[Webkit-unassigned] [Bug 81132] New: Web Inspector: Move all includes behind ENABLE(INSPECTOR) guards

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 14 10:24:21 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=81132

           Summary: Web Inspector: Move all includes behind
                    ENABLE(INSPECTOR) guards
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Web Inspector
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: prybin at chromium.org
                CC: timothy at apple.com, rik at webkit.org, keishi at webkit.org,
                    pmuellr at yahoo.com, joepeck at webkit.org,
                    pfeldman at chromium.org, yurys at chromium.org,
                    bweinstein at apple.com, apavlov at chromium.org,
                    loislo at chromium.org


Throughout inspector codebase most of .cpp file contain ENABLE(INSPECTOR) guards. However corresponding .h files are often included before this guard, i.e. unconditionally. There is a strange implication here that .h files should turn out to be compilable even when INSPECTOR is no enabled.
Since this implication often becomes wrong with development going on, all .h files should go behind ENABLE(INSPECTOR) guards.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list