[Webkit-unassigned] [Bug 77197] [GTK] Handle printing errors in WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77197





--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-03-14 10:05:41 PST ---
(In reply to comment #3)
> (From update of attachment 127987 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=127987&action=review
> 
> OK, looks good to me!

Thanks for reviewing it!

> > Source/WebKit2/UIProcess/API/gtk/WebKitError.h:112
> > + * @WEBKIT_PRINT_ERROR_INVALID_PAGE_RANGE: There are no pages to print
> 
> Nit: Invalid page ranges could include pages that exist, so perhaps saying there are no pages is not the most conceptually correct here. Go for Invalid page range?

Invalid page range sounds good to me.

> > Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp:207
> > +     * finishes after an error and #WebKitPrintOperation::finished signal is emitted
> > +     * after this one.
> 
> Suggestion: replace the last sentence with just The #WebKitPrintOperation::finished signal is emitted after this one.

Ok.

> > Source/WebKit2/UIProcess/API/gtk/tests/TestPrinting.cpp:102
> > +        if (strcmp(gtk_printer_get_name(printer), "Print to File"))
> 
> Hrm. Something just popped on my mind. Does gtk_printer_get_name() return the localized string? I guess all of us run our systems in English, but be good to make this robust.

Yes, it returned the localized string, but gtk_test_init() resets the locale to C for that reason, making sure unit tests always run with the C locale. My system locale is ES indeed, and test work without problems :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.