[Webkit-unassigned] [Bug 80602] Convert some fast/regions pixel tests to reftests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=80602


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #131373|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #4 from Dirk Schulze <krit at webkit.org>  2012-03-14 09:46:51 PST ---
(From update of attachment 131373)
View in context: https://bugs.webkit.org/attachment.cgi?id=131373&action=review

> LayoutTests/ChangeLog:8
> +        Convert some fast/regions pixel tests to reftests
> +        https://bugs.webkit.org/show_bug.cgi?id=80602
> +
> +        Reviewed by NOBODY (OOPS!).

Please add a more detailed description what you changed. Also, you changed some test files, these need comments as well. You can put the comments directly next to/under the file names in the ChangeLog.

> LayoutTests/fast/regions/positioned-objects-inline-static-in-rtl-regions.html:45
> +is contained in. It should fill the left half of the first region.</p>

Should you see red on the page? If so it is a bad tests :) Why did you remove the comment?

> LayoutTests/fast/regions/positioned-objects-inline-static-spanning-regions.html:-55
> -            Some text.<br>
> -             Some text.<br>
> -              Some text.<br>
> -               Some text.<br>
> -                Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br> Some text.<br>      </span>

Why did you remove the text and the break lines?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.