[Webkit-unassigned] [Bug 80627] [Qt][WK2] Move code common to both ProxyAuthentication and Authentication context objects into a base class

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 14 07:51:52 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=80627





--- Comment #3 from Alexander Færøy <ahf at 0x90.dk>  2012-03-14 07:51:52 PST ---
(From update of attachment 130891)
View in context: https://bugs.webkit.org/attachment.cgi?id=130891&action=review

Informal r=me, but I am not a reviewer :-)

> Source/WebKit2/ChangeLog:8
> +

Maybe add a note to the ChangeLog like "This change does not affect the QML API".

> Source/WebKit2/UIProcess/qt/QtDialogRunner.cpp:101
> +class AuthenticationDialogContextObject : public BaseAuthenticationContextObject {

Maybe change this HttpAuthenticationDialogContextObject?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list